Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reference] optimization: push optimizer_runs further by removing getter #90

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chefburger
Copy link
Collaborator

This PR tries to increase optimizer_runs as far as i can while avoiding hitting the contract size limit 24,576.

I experimentally removed 3 getters functions from BinPoolManager so that i can set a bigger optimizer_runs. However it seemed there was not much gas gained from this.

I've set it WIP and would not encourage to merge this considering the extra efforts for removing getter (i.e. external reader, a lot of updating around tests)

@chefburger chefburger marked this pull request as draft June 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant