optimization: support burn onbehalf of other #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of mint and burn function
ChefSnoopy
reviewed
Apr 9, 2024
| if (allowed != type(uint256).max) allowance[from][msg.sender][currency] = allowed - amount; | ||
| } | ||
|
|
||
| _burn(from, currency, amount); |
There was a problem hiding this comment.
It seems that directly using the codes in the _burn function, will save some gas?
// _burn(from, currency, amount);
balanceOf[from][currency] -= amount;
emit Transfer(msg.sender, from, address(0), currency, amount);
There was a problem hiding this comment.
It seems not a big deal in this case probabaly a extra jump ? I feel like _burn gives better readability
ChefSnoopy
previously approved these changes
Apr 9, 2024
ChefMist
previously approved these changes
Apr 11, 2024
There was a problem hiding this comment.
created pancakeswap/pancake-v4-periphery#11 to track since a follow-up update on v4-periphery is required
ChefMist
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes here per discussion:
burn(address from, Currency currency, uint256 amount): ppl can burn others vaultToken to finish payment as long as they have corresponding allowancefunction mint(Currency currency, address to, uint256 amount)tofunction mint(address to, Currency currency, uint256 amount)so as to aligns with burn function