Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opBNB farm #8599

Merged
merged 11 commits into from
Dec 18, 2023
Merged

feat: opBNB farm #8599

merged 11 commits into from
Dec 18, 2023

Conversation

ChefJerry
Copy link
Contributor

copilot:all

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:59pm
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:59pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 2:59pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 2:59pm
blog ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 2:59pm
bridge ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 2:59pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab34601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

Typescript errors check

1926 ts errors detected in all the codebase 😟.

Well done: no ts errors in files changed in this PR! 🎉

chefjackson/action-check-typescript

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 18, 2023
@ChefJerry ChefJerry marked this pull request as ready for review December 18, 2023 07:34
chefjackson
chefjackson reviewed Dec 18, 2023
View reviewed changes
apis/farms/src/v3.ts Outdated
@@ -48,6 +48,10 @@ export const V3_SUBGRAPH_CLIENTS = {
[ChainId.BASE]: new GraphQLClient('https://api.studio.thegraph.com/query/45376/exchange-v3-base/version/latest', {
fetch,
}),
// @todo @Chef-Jerry add opbnb subgraph
[ChainId.OPBNB]: new GraphQLClient('https://opbnb-mainnet-graph.nodereal.io/subgraphs/name/pancakeswap/exchange-v3', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subgraphs are also exported from chains pkg. Let's import from chains

chefjackson
chefjackson previously approved these changes Dec 18, 2023
View reviewed changes
@ChefJerry ChefJerry merged commit c10bc6a into develop Dec 18, 2023
21 checks passed
@ChefJerry ChefJerry deleted the feature/opbnb-farm branch December 18, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChefMomota ChefMomota ChefMomota approved these changes

@chefjackson chefjackson chefjackson left review comments

@0xjojoex 0xjojoex Awaiting requested review from 0xjojoex

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@ChefBingbong ChefBingbong Awaiting requested review from ChefBingbong

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChefJerry @ChefMomota @chefjackson