Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no_implicit_optional mypy check and fix issue #430

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Enable no_implicit_optional mypy check and fix issue #430

merged 3 commits into from
Oct 7, 2023

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Dec 20, 2022 •
edited
Loading

A small step towards mypy --strict mode.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@rnestler rnestler mentioned this pull request Dec 20, 2022
Open
13 tasks
@rnestler rnestler force-pushed the mypy-enable-no-implicit-optional branch from 79203ee to b8e06f1 Compare December 20, 2022 11:13
@rnestler
Copy link
Contributor Author

CI seems flaky? Tests ran successfully before the CHANGES.rst change which hopefully doesn't influence the test.

@rnestler rnestler force-pushed the mypy-enable-no-implicit-optional branch from b8e06f1 to fdcb9c6 Compare February 3, 2023 11:28
@rnestler
Copy link
Contributor Author

rnestler commented Feb 3, 2023

@northernSage You did review #391, want to take a look at this as well?

@rnestler rnestler force-pushed the mypy-enable-no-implicit-optional branch from fdcb9c6 to 017705a Compare March 3, 2023 14:25
@rnestler
Copy link
Contributor Author

rnestler commented Mar 3, 2023

Is there any update / feedback on this PR?

@rnestler rnestler force-pushed the mypy-enable-no-implicit-optional branch from 017705a to af3cf92 Compare May 1, 2023 14:28
@rnestler
Copy link
Contributor Author

rnestler commented May 4, 2023

Bump 🙂

@northernSage
Copy link
Member

Thanks a lot 👍🏻

@northernSage northernSage merged commit 5a6be78 into pallets-eco:master Oct 7, 2023
6 of 7 checks passed
@rnestler rnestler deleted the mypy-enable-no-implicit-optional branch October 9, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northernSage northernSage northernSage approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnestler @northernSage