Add the --enable-preview flag based on the Baseline-Enable-Preview jar manifest attribute
#1365
Conversation
Generate changelog in
|
| entry -> entry.getValue().enablePreview().get(), | ||
| entry -> entry.getKey().getName(), | ||
| () -> MultimapBuilder.hashKeys().arrayListValues().build())) | ||
| .asMap(); |
There was a problem hiding this comment.
this is where I'd intuitively reach for streamex and an entrystream, but I think we've found that including too many deps in our gradle plugins causes sad times right?
| + JarManifestModuleInfo.ENABLE_PREVIEW_ATTRIBUTE + " attribute (" + enablePreviewVersion | ||
| + ") from:\n" + Iterables.getOnlyElement(enablePreviewFromJar.values())); | ||
| return Stream.of("--enable-preview"); | ||
| } |
There was a problem hiding this comment.
This method is pretty complicated, I think we want to stream through the jars, fail if we see any with ENABLE_PREVIEW_ATTRIBUTE != javaVersion, and add the flag if we've seen any ENABLE_PREVIEW_ATTRIBUTE attrs?
imo the Map<String, Collection<String>> enablePreviewFromJar makes things difficult to grok
There was a problem hiding this comment.
Sorry for the delay, I've updated to use less stream-y stuff... think this should be a bit more readable now!
Before this PR
I've recently (palantir/gradle-baseline#2322) added functionality to gradle-baseline so that folks can opt in to java's
--enable-previewfunctionality by setting something likejavaVersions { distributionTarget = '17_PREVIEW' }. Baseline applies the flag to all the compile time tasks, but we also need this to propagate to the production runtime jvm args.We decided to convey the information using a jar attribute like
Baseline-Enable-Preview: 17. This way if different jars tried to select conflicting runtime values we can provide clear errors.See https://openjdk.org/jeps/12 for details of the behaviour of
--enable-preview.After this PR
==COMMIT_MSG==
createLaunchConfigtask automatically adds the--enable-previewflag based on theBaseline-Enable-Previewjar manifest attribute==COMMIT_MSG==
Possible downsides?