Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2086] feat: add endpoint for expose static error page #85

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Sep 4, 2024

This PR contains a new endpoint that permits to expose static HTML resources in order to be used from APIM policy.

List of Changes

  • Add new endpoint for the exposition of error landing static page

Motivation and Context

This feature is required in order to use the static pages in other contexts without duplicating the HTML code

How Has This Been Tested?

  • Tested in local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Sep 4, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner September 4, 2024 07:32
Copy link

github-actions bot commented Sep 4, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

github-actions bot commented Sep 4, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments, the core update LGTM 👍

Copy link

github-actions bot commented Sep 4, 2024

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

@andrea-deri andrea-deri merged commit fca0d3a into main Sep 4, 2024
6 of 8 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-2086 branch September 4, 2024 07:50
Copy link

sonarcloud bot commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants