Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1940] fix: resolved bug on wrong stamp conversion #51

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

andrea-deri
Copy link
Contributor

This PR contains a fix on a bug found during a test with real creditor institution. This bug is related to the digital stamps (Marca da Bollo Digitale) because its insertion in GPD debt position was wrongly formed. Nodo dei Pagamenti found the error because the generated data was greater than a defined dimension. The error was related to a wrong conversion from bytearray to Base64 format.

List of Changes

  • Resolved missing encoding conversion of digital stamp from Base64

Motivation and Context

This change is required in order to resolve a bug on digital stamp

How Has This Been Tested?

  • Tested in local environment
  • Tested in UAT environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

github-actions bot commented Jul 9, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

github-actions bot commented Jul 9, 2024

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

Copy link

sonarcloud bot commented Jul 9, 2024

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrea-deri andrea-deri merged commit fa7094d into main Jul 9, 2024
13 of 16 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-1940 branch July 12, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants