Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1837] Refactoring JUnit tests #27

Merged

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

Fixing and refactoring junit tests

Motivation and Context

Needed to properly fix the various junit tests in the repository

How Has This Been Tested?

Manually through junit

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the bug Something isn't working label Jun 14, 2024
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, ignore-for-release]

@FedericoRuzzier
Copy link
Contributor Author

update_code

Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat work! 🚀

@andrea-deri andrea-deri changed the title Pagopa 1837 test sistemare j unit in repository wisp converter [PAGOPA-1837] Refactoring JUnit tests Jun 17, 2024
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

Copy link

sonarcloud bot commented Jun 17, 2024

@andrea-deri andrea-deri merged commit c54b430 into main Jun 17, 2024
9 of 14 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-1837-test-sistemare-j-unit-in-repository-wisp-converter branch June 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants