Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1832] fix: Check station related to payment notice during existing payment position analysis #25

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Jun 11, 2024

With this PR, the WISP-Converter application will include a new strategy for analyze payment positions from GPD. This strategy must execute a check on station that will be used on the Nuovo Modello Unico's payment next steps and the analysis are useful to better handle payment positions, either if they are in valid state or in invalid state. In fact, in valid state the check is related to avoid the possibility of using a station misconfigured; in invalid state the check is related to the possibility to exclude the send of paaInviaRT request to creditor institutions, but checking if the station is used for GPD onboarding.
Other changes refers to several little refactoring points, made in order to made the code more readable and avoiding duplicated strategies of data-accesses.

List of Changes

  • Add explicit check on station during the analysis of existing payment positions
  • Updated getRedirectURL in order to use the refactored "retrieve station from cache" method
  • Refactored various section, defining common strategy for accessing to cached data and other standard data structures (like payment position's DTOs)
  • Set a first definition of openapiDefinition field for AppErrorCodeMessageEnum: on next developments it will be used for extract user-friendly descriptions about the error to be set in OpenAPI specifications
  • Added new parameter about GPD-Payment's endpoint, setting its placeholder on Helm in order to permit dynamic configuration

Motivation and Context

These changes are required because it is necessary to add a new check on used station

How Has This Been Tested?

Tested in local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Jun 11, 2024
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

@andrea-deri andrea-deri merged commit dd28310 into main Jun 12, 2024
5 of 8 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-1832-check-station-on-pp-analysis branch June 12, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant