[PAGOPA-1832] fix: Check station related to payment notice during existing payment position analysis #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the WISP-Converter application will include a new strategy for analyze payment positions from GPD. This strategy must execute a check on station that will be used on the Nuovo Modello Unico's payment next steps and the analysis are useful to better handle payment positions, either if they are in valid state or in invalid state. In fact, in valid state the check is related to avoid the possibility of using a station misconfigured; in invalid state the check is related to the possibility to exclude the send of
paaInviaRT
request to creditor institutions, but checking if the station is used for GPD onboarding.Other changes refers to several little refactoring points, made in order to made the code more readable and avoiding duplicated strategies of data-accesses.
List of Changes
getRedirectURL
in order to use the refactored "retrieve station from cache" methodopenapiDefinition
field forAppErrorCodeMessageEnum
: on next developments it will be used for extract user-friendly descriptions about the error to be set in OpenAPI specificationsMotivation and Context
These changes are required because it is necessary to add a new check on used station
How Has This Been Tested?
Tested in local environment
Screenshots (if appropriate):
Types of changes
Checklist: