Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made changes on flow due to wrong Receipt handling #24

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Jun 11, 2024

After a test session on which the whole flow is tested, some bugs were found. This PR aims to resolve these bugs and add more flexibility on future development, refactoring some existing code in more stable one.

List of Changes

  • Fixed error on amount setting, wrongly casted as long value
  • Set switchToExpired always to false in debt position creation
  • Set dueDate always as today+1 in debt position update
  • Better handling of invalid debt positions, preparing all for receipt generation
  • Changed RE generation on invalid debt position analysis, moved before receipt generation

Motivation and Context

These changes are required in order to fix the flow and correctly handle RPT payments.

How Has This Been Tested?

  • Tested in local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

@andrea-deri andrea-deri merged commit 5f0d7a3 into main Jun 11, 2024
13 of 18 checks passed
@andrea-deri andrea-deri deleted the fixes-after-test branch June 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant