Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2154] fix(debtor info): replace fullName if is blank #137

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: pagopa-wisp-converter
description: A service that permits to handle nodoInviaRPT and nodoInviaCarrelloRPT request from WISP, interfacing them with GPD system
type: application
version: 0.222.0
appVersion: 0.4.4
version: 0.223.0
appVersion: 0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank
dependencies:
- name: microservice-chart
version: 3.0.0
Expand Down
2 changes: 1 addition & 1 deletion helm/values-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-wisp-converter
tag: "0.4.4"
tag: "0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-wisp-converter
tag: "0.4.4"
tag: "0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-uat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-wisp-converter
tag: "0.4.4"
tag: "0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion openapi/openapi.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion openapi/openapi_redirect.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"openapi": "3.0.1",
"info": {
"title": "WISP-Converter-redirect",
"version": "0.4.4"
"version": "0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank"
},
"servers": [
{
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<groupId>it.gov.pagopa</groupId>
<artifactId>wisp-converter</artifactId>
<version>0.4.4</version>
<version>0.4.4-1-PAGOPA-2154-bug-richieste-con-anagrafica-pagatore-blank</version>
<name>pagoPA WISP Converter</name>
<description>A service that permits to handle nodoInviaRPT and nodoInviaCarrelloRPT request from WISP, converting them in NMU payments.</description>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ private List<PaymentPositionModelDto> extractPaymentPositionsForNonMultiBenefici
// finally, generate the payment position and add the payment option
String creditorInstitutionId = paymentExtractedFromRPT.getDomain().getDomainId();
PaymentPositionModelDto paymentPosition = mapper.toPaymentPosition(rptContent);
// rptContent.getRpt().getPayer().getName().isBlank()
paymentPosition.setIupd(generateIUPD(creditorInstitutionId));
paymentPosition.setCompanyName(configCacheService.getCreditorInstitutionNameFromCache(creditorInstitutionId));
paymentPosition.setPaymentOption(List.of(paymentOption));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ public interface DebtPositionMapper {
@Mapping(source = "rpt.payer.subjectUniqueIdentifier.type", target = "type")
@Mapping(source = "rpt.payer.subjectUniqueIdentifier.code", target = "fiscalCode")
@Mapping(source = "rpt.domain.domainName", target = "companyName")
@Mapping(source = "rpt.payer.name", target = "fullName")
// @Mapping(source = "rpt.payer.name", target = "fullName")
@Mapping(expression = "java(rptContentDTO.getRpt().getPayer().getName().isBlank() ? \"BLANK_DEBTOR\" : rptContentDTO.getRpt().getPayer().getName())", target = "fullName")
@Mapping(source = "rpt.payer.address", target = "streetName")
@Mapping(source = "rpt.payer.streetNumber", target = "civicNumber")
@Mapping(source = "rpt.payer.postalCode", target = "postalCode")
Expand Down