Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2170] fix: resolved bug on idempotency key check #117

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Sep 20, 2024

List of Changes

  • Changed idempotency key retrieve, previously bad performed using not-set partition key as search filter.

Motivation and Context

This change is required in order to correctly perform idempotency handling.

How Has This Been Tested?

  • Tested in local environment
  • Tested in DEV environment
  • Tested in UAT environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Sep 20, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner September 20, 2024 13:47
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@FedericoRuzzier
Copy link
Contributor

Check code review result, I think it fails

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants