Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2150] fix: changed wrongly referenced creditor institution in RT header #110

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Sep 18, 2024

This PR contains a fix made on RT generation when an error occurred during convert process. In particular, the fix is made on field identificativoDominio, on which no valid value was set: the creditor institution received this RT but declared it as invalid, so it returned an error response.

List of Changes

  • Replaced identificativoDominio with field extracted from RPT instead of session data.

Motivation and Context

This change is required in order to resolve the bug on RT send.

How Has This Been Tested?

  • Tested in UAT environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri added bug Something isn't working patch labels Sep 18, 2024
@andrea-deri andrea-deri self-assigned this Sep 18, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner September 18, 2024 12:15
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@andrea-deri andrea-deri changed the title fix: changed wrongly referenced creditor instition id in KO RT fix: changed wrongly referenced creditor institution in RT header Sep 18, 2024
@andrea-deri andrea-deri changed the title fix: changed wrongly referenced creditor institution in RT header [PAGOPA-2150] fix: changed wrongly referenced creditor institution in RT header Sep 18, 2024
@aomegax aomegax merged commit 1b05d03 into main Sep 18, 2024
10 of 12 checks passed
@aomegax aomegax deleted the release-v0.2-fix-rt-domainid-error branch September 18, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants