Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored log traces for AppInsight tuning #103

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Sep 16, 2024

This PR contains some changes made on logs in order to reduce the verbosity at INFO level and, automatically, reduce costs related to Application Insights log monitoring.

List of Changes

  • Moved some info logs to debug level
  • Refactored setSessionDataInfoInMDC(), moved in MDCUtils as setSessionDataInfo()
  • Refactored some log messages

Motivation and Context

This change is made in order to reduce the quantity of not useful logs generated by service.

How Has This Been Tested?

  • Tested in local environment
  • Tested in DEV environment

Screenshots (if appropriate):

Types of changes

  • Chore (non-breaking change which does not change flow or fixes an issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Sep 16, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner September 16, 2024 11:07
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@andrea-deri andrea-deri changed the title fix: refactored log traces for AppInsight tuning chore: refactored log traces for AppInsight tuning Sep 16, 2024
@andrea-deri andrea-deri changed the base branch from main to release-v0.2 September 17, 2024 06:35
@andrea-deri andrea-deri merged commit 2fbe1c0 into release-v0.2 Sep 17, 2024
1 check passed
@andrea-deri andrea-deri deleted the fix-log-filtering branch September 17, 2024 06:35
@andrea-deri andrea-deri mentioned this pull request Sep 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant