Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2122] fix: actualization of multibeneficiary paSendRTV2 #102

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Sep 13, 2024

This PR contains a fix made in order to correctly generate the OK receipts to be sent to creditor institution. The generation of multibeneficiary cart's OK receipt was not correctly handled, generating and sending only a single paaInviaRT that contains all RPTs references. With this fix, the paaInviaRT are correctly defined for each RPT and the related amount is actualized with transfers amount defined in cart.

List of Changes

  • Fix generation of RTs from paSendRTV2 for multibeneficiary carts
  • Fix wrong mapping of codiceIdentificativoUnivoco field, correctly setting the SWIFT code instead of its fiscal code

Motivation and Context

These changes are required in order to generate a correct OK receipt

How Has This Been Tested?

  • Tested in local environment
  • Tested in DEV environment
  • Tested in UAT environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Sep 13, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner September 13, 2024 16:21
Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@aomegax aomegax changed the base branch from main to release-v0.2 September 16, 2024 15:07
@aomegax aomegax merged commit a1dcf8d into release-v0.2 Sep 16, 2024
1 check passed
@aomegax aomegax deleted the PAGOPA-2122 branch September 16, 2024 15:20
@andrea-deri andrea-deri mentioned this pull request Sep 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants