[PAGOPA-2146] fix

pagopa · Sep 20, 2024 · 38d0939 · 38d0939
1 parent 49d0472
commit 38d0939
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/src/main/java/it/gov/pagopa/wispconverter/service/RecoveryService.java b/src/main/java/it/gov/pagopa/wispconverter/service/RecoveryService.java
@@ -148,7 +148,7 @@ private boolean recoverReceiptKOByRecoveryPayment(String dateFrom, String dateTo
                     String sessionId = event.getSessionId();
 
                     log.info("[RECOVERY-MISSING-RT] Recovery with receipt-ko for ci = {}, iuv = {}, ccp = {}, sessionId = {}", ci, iuv, ccp, sessionId);
-                    this.recoverReceiptKO(ci, iuv, sessionId, ccp, dateFrom, dateTo);
+                    this.recoverReceiptKO(ci, iuv, ccp, sessionId, dateFrom, dateTo);
                 }
             } catch (Exception e) {
                 generateRE(Constants.PAA_INVIA_RT, "Failure", InternalStepStatus.RT_END_RECONCILIATION_PROCESS, ci, iuv, ccp, null);
@@ -216,7 +216,7 @@ private static Set<String> getWISPInterruptStatusSet() {
                 "GENERATED_NAV_FOR_NEW_PAYMENT_POSITION",
                 "CREATED_NEW_PAYMENT_POSITION_IN_GPD",
                 "GENERATED_CACHE_ABOUT_RPT_FOR_DECOUPLER",
-                "GENERATED_CACHE_ABOUT_RPT_FOR_RT_GENERATION",
+                EVENT_TYPE_FOR_RECEIPTKO_SEARCH,
                 "SAVED_RPT_IN_CART_RECEIVED_REDIRECT_URL_FROM_CHECKOUT"
         );
     }

diff --git a/src/test/java/it/gov/pagopa/wispconverter/endpoint/RecoveryTest.java b/src/test/java/it/gov/pagopa/wispconverter/endpoint/RecoveryTest.java
@@ -73,7 +73,7 @@ void testRecoverReceiptKOForCreditorInstitution_500() throws Exception {
     }
 
     @Test
-    public void testRecoverReceiptKOForCreditorInstitutionAndIUV() throws Exception {
+    void testRecoverReceiptKOForCreditorInstitutionAndIUV() throws Exception {
         String ci = "77777777777";
         String iuv = "00000000000000000";
         String dateFrom = "2024-09-03";
@@ -88,7 +88,7 @@ public void testRecoverReceiptKOForCreditorInstitutionAndIUV() throws Exception
     }
 
     @Test
-    public void testRecoverReceiptKOForCreditorInstitutionAndIUV_500() throws Exception {
+    void testRecoverReceiptKOForCreditorInstitutionAndIUV_500() throws Exception {
         String ci = "77777777777";
         String iuv = "00000000000000000";
         String dateFrom = "2024-09-03";

diff --git a/src/test/java/it/gov/pagopa/wispconverter/service/RecoveryServiceTest.java b/src/test/java/it/gov/pagopa/wispconverter/service/RecoveryServiceTest.java
@@ -44,7 +44,7 @@ public void setup() {
     }
 
     @Test
-    public void testRecoverReceiptKO() throws Exception {
+    void testRecoverReceiptKO() {
         // Arrange
         String dateFrom = "2024-09-05";
         String dateTo = "2024-09-09";
@@ -55,7 +55,6 @@ public void testRecoverReceiptKO() throws Exception {
         List<ReEventEntity> rtSuccessReEventEntity = List.of();
 
         when(reRepository.findBySessionIdAndStatus(anyString(), anyString(), anyString(), anyString())).thenReturn(rtSuccessReEventEntity);
-        // doNothing().when(cacheRepository).insert(anyString(), anyString(), anyLong(), any(ChronoUnit.class), anyBoolean());
         doNothing().when(receiptService)
                 .sendRTKoFromSessionId(anyString(), any());
         doNothing().when(reService).addRe(any(ReEventDto.class));
@@ -68,7 +67,7 @@ public void testRecoverReceiptKO() throws Exception {
     }
 
     @Test
-    public void testRecoverReceiptKOForCreditorInstitution_Success() {
+    void testRecoverReceiptKOForCreditorInstitution_Success() {
         // Arrange
         String creditorInstitution = "77777777777";
         String dateFrom = "2024-09-05";
@@ -86,7 +85,7 @@ public void testRecoverReceiptKOForCreditorInstitution_Success() {
     }
 
     @Test
-    public void testRecoverReceiptKOForCreditorInstitution_LowerBoundFailure() {
+    void testRecoverReceiptKOForCreditorInstitution_LowerBoundFailure() {
         // Arrange
         String creditorInstitution = "77777777777";
         String dateFrom = "2024-09-01";  // Date earlier than valid start date
@@ -100,7 +99,7 @@ public void testRecoverReceiptKOForCreditorInstitution_LowerBoundFailure() {
     }
 
     @Test
-    public void testRecoverReceiptKOForCreditorInstitution_UpperBoundFailure() {
+    void testRecoverReceiptKOForCreditorInstitution_UpperBoundFailure() {
         // Arrange
         String creditorInstitution = "77777777777";
         String dateFrom = "2024-09-05";
@@ -115,7 +114,7 @@ public void testRecoverReceiptKOForCreditorInstitution_UpperBoundFailure() {
     }
 
     @Test
-    public void testRecoverReceiptKOByIUV() {
+    void testRecoverReceiptKOByIUV() {
         // Arrange
         String dateFrom = "2024-09-05";
         String dateTo = "2024-09-09";