Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-198] feat: Removed check on paymentInfo.remittanceInformation #68

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[PRDP-198] feat: Removed check on paymentInfo.remittanceInformation #68

merged 2 commits into from
Nov 10, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Nov 9, 2023

List of Changes

  • Removed check on paymentInfo.remittanceInformation
  • Updated unit tests

Motivation and Context

Allow to generate receipt without cart.item.subject

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the patch label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pasqualespica pasqualespica merged commit 58197b8 into main Nov 10, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @pasqualespica