Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-162] feat: Improve error message #47

Merged
merged 7 commits into from
Oct 19, 2023
Merged

[PRDP-162] feat: Improve error message #47

merged 7 commits into from
Oct 19, 2023

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Oct 18, 2023 •
edited
Loading

List of Changes

  • Set payer error messages in specific field

Motivation and Context

Store error messages for payer and debtor in different fields

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

giomella added 4 commits October 19, 2023 11:35
[PRDP-162] set specific errors section for payer when pdf generation …
78c8a1f 
…fail
[PRDP-162] fix sonar issue
08f14bd
[PRDP-162] fix rebase
a777001
Merge branch 'PRDP-162-improve-error-messages' of https://github.com/…
dced22a 
…pagopa/pagopa-receipt-pdf-generator into PRDP-162-improve-error-messages

# Conflicts:
#	src/main/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImpl.java
#	src/test/java/it/gov/pagopa/receipt/pdf/generator/service/impl/GenerateReceiptPdfServiceImplTest.java
@github-actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@gioelemella gioelemella marked this pull request as ready for review October 19, 2023 09:42
pasqualespica
pasqualespica approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@pasqualespica pasqualespica merged commit 1824efb into main Oct 19, 2023
6 of 10 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 19, 2023 10:15 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 19, 2023 10:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@gioelemella gioelemella

Labels
minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @pasqualespica