Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-170] Changed value property for total in receipt #39

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Oct 17, 2023

List of Changes

Changed property for total in receipt from transaction.amount to transaction.grandTotal, to include the fees

Motivation and Context

Issue PRDP-170
The final total was coming from the wrong property and wasn't including the fees

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

1 similar comment
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pasqualespica pasqualespica merged commit 97eef1e into main Oct 17, 2023
19 of 24 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 17, 2023 08:47 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 17, 2023 08:55 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants