Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-161] feat: Improve temp file handling #37

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • create temp directory at the beginning of the function execution
  • clear the temp directory at the end of the function execution
  • avoid to create the temp directory on PDF Engine response
  • updated unit tests

Motivation and Context

Reduce the operation on file system to improve performance

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added enhancement New feature or request patch labels Oct 16, 2023
@gioelemella gioelemella changed the title [PRDP-161 feat: Improve temp file handling [PRDP-161] feat: Improve temp file handling Oct 16, 2023
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

73.6% 73.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 🚀

@pasqualespica pasqualespica merged commit 1195bf4 into main Oct 16, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants