Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-70] fix: Update unit tests #28

Merged
merged 6 commits into from
Oct 6, 2023
Merged

[PRDP-70] fix: Update unit tests #28

merged 6 commits into from
Oct 6, 2023

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • Updated unit test for GenerateReceiptPdfService and GenerateReceiptPdf
  • do some refactor
  • fixed receipt already created check

Motivation and Context

Update unit tests

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.0% 81.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pasqualespica pasqualespica merged commit 21983aa into main Oct 6, 2023
9 of 12 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 6, 2023 13:07 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 6, 2023 13:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants