Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-70] Template mapping continuing develop #23

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Oct 5, 2023

List of Changes

  • Added template values mapping
  • Fixed condition on payer & debtor template generation
  • Added IUR field to PaymentInfo class to match with biz-event-datastore changes

Motivation and Context

Issue PRDP-70

How Has This Been Tested?

Run unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

34.8% 34.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pasqualespica pasqualespica merged commit 0db85ac into main Oct 5, 2023
11 of 16 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 5, 2023 10:07 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 5, 2023 10:08 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 5, 2023 10:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants