-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRDP-127] feat: Refactoring receipt-pdf-datastore generate PDF function into receipt-pdf-generator #2
[PRDP-127] feat: Refactoring receipt-pdf-datastore generate PDF function into receipt-pdf-generator #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']
This pull request does not contain a valid label. Please add one of the following labels: |
1 similar comment
This pull request does not contain a valid label. Please add one of the following labels: |
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Comment this PR with update_code to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work a lot of stuffs 🚀
List of Changes
Extracted the "GenerateReceiptPdf" & "MenageReceiptPoisonQueue" & "RetryReviewedPoisonMessagesProcessor" functions from receipt-pdf-datastore into this repository.
Motivation and Context
Issue PRDP-127
Needed for a better management of the resources used by the functions
How Has This Been Tested?
All previously present tests have been run
Types of changes
Checklist: