[PRDP-127] feat: Refactoring receipt-pdf-datastore generate PDF function into receipt-pdf-generator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svariant
added
enhancement
|
This pull request does not contain a valid label. Please add one of the following labels: |
1 similar comment
|
This pull request does not contain a valid label. Please add one of the following labels: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Comment this PR with update_code to update |
pasqualespica
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Extracted the "GenerateReceiptPdf" & "MenageReceiptPoisonQueue" & "RetryReviewedPoisonMessagesProcessor" functions from receipt-pdf-datastore into this repository.
Motivation and Context
Issue PRDP-127
Needed for a better management of the resources used by the functions
How Has This Been Tested?
All previously present tests have been run
Types of changes
Checklist: