Merge pull request #18 from pagopa/PRDP-148-feat-rework-pdf-name

[PRDP-148] Removed fiscal code from pdf name
pagopa · Oct 4, 2023 · eb9816d · eb9816d
2 parents d460433 + 3777975
commit eb9816d
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/GenerateReceiptPdfService.java b/src/main/java/it/gov/pagopa/receipt/pdf/generator/service/GenerateReceiptPdfService.java
@@ -53,7 +53,7 @@ public PdfGeneration handlePdfsGeneration(boolean generateOnlyDebtor, Receipt re
                             receipt.getMdAttach().getUrl() == null ||
                             receipt.getMdAttach().getUrl().isEmpty())
             ) {
-                pdfGeneration.setDebtorMetadata(generatePdf(bizEvent, debtorCF, true));
+                pdfGeneration.setDebtorMetadata(generatePdf(bizEvent, true));
             }
         } else {
             //Generate debtor's partial PDF
@@ -62,15 +62,15 @@ public PdfGeneration handlePdfsGeneration(boolean generateOnlyDebtor, Receipt re
                             receipt.getMdAttach().getUrl() == null ||
                             receipt.getMdAttach().getUrl().isEmpty())
             ) {
-                pdfGeneration.setDebtorMetadata(generatePdf(bizEvent, debtorCF, false));
+                pdfGeneration.setDebtorMetadata(generatePdf(bizEvent, false));
             }
             //Generate payer's complete PDF
             if (payerCF != null &&
                     (receipt.getMdAttachPayer() == null ||
                             receipt.getMdAttachPayer().getUrl() == null ||
                             receipt.getMdAttachPayer().getUrl().isEmpty())
             ) {
-                pdfGeneration.setPayerMetadata(generatePdf(bizEvent, payerCF, true));
+                pdfGeneration.setPayerMetadata(generatePdf(bizEvent, true));
             }
         }
 
@@ -81,11 +81,10 @@ public PdfGeneration handlePdfsGeneration(boolean generateOnlyDebtor, Receipt re
      * Handles PDF generation and saving to storage
      *
      * @param bizEvent         Biz-event from queue message
-     * @param fiscalCode       Debtor or payer fiscal code
      * @param completeTemplate Boolean that indicates what template to use
      * @return PDF metadata retrieved from Blob Storage or relative error message
      */
-    private PdfMetadata generatePdf(BizEvent bizEvent, String fiscalCode, boolean completeTemplate) {
+    private PdfMetadata generatePdf(BizEvent bizEvent, boolean completeTemplate) {
         PdfEngineRequest request = new PdfEngineRequest();
         PdfMetadata response = new PdfMetadata();
 
@@ -110,7 +109,7 @@ private PdfMetadata generatePdf(BizEvent bizEvent, String fiscalCode, boolean co
 
             if (pdfEngineResponse.getStatusCode() == HttpStatus.SC_OK) {
                 //Save the PDF
-                String pdfFileName = bizEvent.getId() + fiscalCode;
+                String pdfFileName = bizEvent.getId() + "_" + (completeTemplate ? "p" : "d");
 
                 handleSaveToBlobStorage(pdfEngineResponse, response, pdfFileName);