Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-1359] fix: Update partially PAID case #77

Merged
merged 3 commits into from
Nov 23, 2023
Merged

[PAGOPA-1359] fix: Update partially PAID case #77

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1d9995
[PAGOPA-1359] fix: Update status check
cap-ang Nov 20, 2023
d0766f2
[PAGOPA-1359] fix: Update JUnit test
cap-ang Nov 23, 2023
4938de0
[PAGOPA-1359] fix: Add check on `PAA_PAGAMENTO_SCADUTO` exception
cap-ang Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/main/java/it/gov/pagopa/payments/service/PartnerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,7 @@ public PaVerifyPaymentNoticeRes paVerifyPaymentNotice(PaVerifyPaymentNoticeReq r
request.getQrCode().getNoticeNumber());
try {
result = this.generatePaVerifyPaymentNoticeResponse(paymentOption);
}
catch (Exception e){
} catch (Exception e) {
log.error("[paVerifyPaymentNotice] paymentOption {}", paymentOption, e);
throw e;
}
Expand Down Expand Up @@ -340,8 +339,8 @@ private void checkDebtPositionStatus(PaymentsModelResponse paymentOption) {
|| paymentOption.getDebtPositionStatus().equals(DebtPositionStatus.PUBLISHED)) {
log.error(DEBT_POSITION_STATUS_ERROR + paymentOption.getDebtPositionStatus() + iuvLog);
throw new PartnerValidationException(PaaErrorEnum.PAA_PAGAMENTO_SCONOSCIUTO);
} else if (paymentOption.getDebtPositionStatus().equals(DebtPositionStatus.PARTIALLY_PAID)
|| paymentOption.getDebtPositionStatus().equals(DebtPositionStatus.PAID)
} else if (paymentOption.getDebtPositionStatus().equals(DebtPositionStatus.PAID)
|| paymentOption.getStatus().equals(PaymentOptionStatus.PO_PAID)
|| paymentOption.getDebtPositionStatus().equals(DebtPositionStatus.REPORTED)) {
log.error(DEBT_POSITION_STATUS_ERROR + paymentOption.getDebtPositionStatus() + iuvLog);
throw new PartnerValidationException(PaaErrorEnum.PAA_PAGAMENTO_DUPLICATO);
Expand Down Expand Up @@ -569,23 +568,20 @@ private CtTransferPAV2 getTransferResponseV2(
return transferPA;
}

private CtMapEntry getPaymentOptionMetadata(
PaymentOptionMetadataModel metadataModel) {
private CtMapEntry getPaymentOptionMetadata(PaymentOptionMetadataModel metadataModel) {
CtMapEntry ctMapEntry = new CtMapEntry();
ctMapEntry.setKey(metadataModel.getKey());
ctMapEntry.setValue(metadataModel.getValue());
return ctMapEntry;
}

private CtMapEntry getTransferMetadata(
TransferMetadataModel metadataModel) {
private CtMapEntry getTransferMetadata(TransferMetadataModel metadataModel) {
CtMapEntry ctMapEntry = new CtMapEntry();
ctMapEntry.setKey(metadataModel.getKey());
ctMapEntry.setValue(metadataModel.getValue());
return ctMapEntry;
}


/**
* The method return iban given transferType and transfer, according to
* https://pagopa.atlassian.net/wiki/spaces/PAG/pages/96403906/paGetPayment#trasferType
Expand Down
Loading