Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1359] fix: Update partially PAID case #77

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Nov 20, 2023

List of Changes

checkDebtPositionStatus is called in paVerifyPaymentNotice and manageGetPaymentRequest.

The method checkDebtPositionStatus has been updated so that a payment position in PARTIALLY_PAID state does not generate a PAGAMENTO_DUPLICATO type exception. Specifically, the condition is replaced through a check on the payment option state, that is, the payment option must not be in state PO_PAID.

Add check on PAA_PAGAMENTO_SCADUTO exception: when Payment Option dueDate has been passed the payment is considered overdue.

Motivation and Context

Fix check on paVerifyPaymentNotice SOAP action.

How Has This Been Tested?

Local environment (gpd-payments) versus DEV instances (pgsql, gpd-core).
Integration test in UAT environment.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Nov 20, 2023
@cap-ang cap-ang added the bug Something isn't working label Nov 20, 2023
@cap-ang cap-ang marked this pull request as ready for review November 20, 2023 17:15
@cap-ang cap-ang requested a review from a team as a code owner November 20, 2023 17:15
Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 👍

Copy link
Collaborator

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix junit and smoke before merge

@cap-ang
Copy link
Contributor Author

cap-ang commented Nov 23, 2023

update_code

Copy link

Update Code is failed. Please retry.

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarcloud bot commented Nov 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.9% 94.9% Coverage
12.8% 12.8% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@cap-ang cap-ang merged commit 0e25f52 into main Nov 23, 2023
9 of 14 checks passed
@cap-ang cap-ang deleted the PAGOPA-1359-partially-payments branch November 23, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants