Merge pull request #56 from pagopa/PAGOPA-1238-gpd-payments-get-recei…

…pts-422 fix: Update PaymentsService UNPROCESSABLE_RECEIPT exception raising [PAGOPA-1238]
pagopa · Sep 21, 2023 · dbff06f · dbff06f
2 parents e4c8d4c + a3ff21f
commit dbff06f
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/helm/Chart.yaml b/helm/Chart.yaml
@@ -2,8 +2,8 @@ apiVersion: v1
 name: pagopa-gpd-payments
 description: Microservice that exposes API for payment receipts retrieving and other operations
 type: application
-version: 0.21.0
-appVersion: 0.9.0
+version: 0.22.0
+appVersion: 0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422
 dependencies:
   - name: microservice-chart
     version: 1.21.0

diff --git a/helm/values-dev.yaml b/helm/values-dev.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.9.0"
+    tag: "0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/helm/values-prod.yaml b/helm/values-prod.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.9.0"
+    tag: "0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/helm/values-uat.yaml b/helm/values-uat.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.9.0"
+    tag: "0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/openapi/openapi.json b/openapi/openapi.json
@@ -4,7 +4,7 @@
     "title": "PagoPA API Payments",
     "description": "Payments",
     "termsOfService": "https://www.pagopa.gov.it/",
-    "version": "0.9.0"
+    "version": "0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422"
   },
   "servers": [
     {

diff --git a/pom.xml b/pom.xml
@@ -13,7 +13,7 @@
 
     <groupId>it.gov.pagopa</groupId>
     <artifactId>payments</artifactId>
-    <version>0.9.0</version>
+    <version>0.9.0-1-PAGOPA-1238-gpd-payments-get-receipts-422</version>
     <name>Payments</name>
     <description>Payments</description>
 

diff --git a/src/main/java/it/gov/pagopa/payments/service/PaymentsService.java b/src/main/java/it/gov/pagopa/payments/service/PaymentsService.java
@@ -98,7 +98,7 @@ public void checkGPDDebtPosStatus(TableEntity receipt, TableClient tableClient)
             if (!tableEntity.getProperty(STATUS_PROPERTY).toString().trim().equalsIgnoreCase(Status.PAID.name())) {
                 PaymentsModelResponse paymentOption =
                         gpdClient.getPaymentOption(tableEntity.getPartitionKey(), tableEntity.getRowKey());
-                if (null != paymentOption && !PaymentOptionStatus.PO_PAID.equals(paymentOption.getStatus())) {
+                if (paymentOption != null && paymentOption.getStatus().equals(PaymentOptionStatus.PO_UNPAID)) {
                     throw new AppException(
                             AppError.UNPROCESSABLE_RECEIPT,
                             paymentOption.getStatus(),