Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PQ-116] - get org. receipt date fromat #83

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

aferracci
Copy link
Contributor

@aferracci aferracci commented Aug 5, 2024

List of Changes

Fixed getOrganizationReceipt output date format for the following fields:

  • applicationDate
  • paymentDateTime
  • transferDate

Fixed email field duplicate output

Motivation and Context

As reported by SMO issue, the format of the fields listed above were no compliant with the specifications, date format was array of int instead of formatted string yyyy-MM-dd.

As reported by users the email output was duplicated, causing problems with the various mappings

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aferracci aferracci requested a review from a team as a code owner August 5, 2024 13:03
@aferracci aferracci changed the title fix - get org. receipt date fromat fix [PQ-116] get org. receipt date fromat Aug 5, 2024
Copy link

sonarcloud bot commented Aug 5, 2024

@aferracci aferracci changed the title fix [PQ-116] get org. receipt date fromat fix: [PQ-116] - get org. receipt date fromat Aug 5, 2024
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pasqualespica pasqualespica merged commit bd40c8e into main Aug 28, 2024
14 of 18 checks passed
@pasqualespica pasqualespica deleted the PQ-116-fix-getorgreceipt-date-format branch August 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants