IMN-842 - Removing uuid and using crypto #1127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
commented
Oct 23, 2024
| @@ -25,16 +25,13 @@ | |||
| "pagopa-interop-commons-test": "workspace:*", | |||
| "@types/uuid": "9.0.8", | |||
| "@types/adm-zip": "0.5.5", | |||
| "pagopa-interop-commons-test": "workspace:*", | |||
There was a problem hiding this comment.
Unrelated, the dependency was duplicated
ecamellini
commented
Oct 23, 2024
| "prettier": "2.8.8", | ||
| "testcontainers": "10.9.0", | ||
| "ts-node": "10.9.2", | ||
| "typescript": "5.4.5", | ||
| "vitest": "1.6.0" | ||
| }, | ||
| "dependencies": { | ||
| "ts-pattern": "5.2.0", |
There was a problem hiding this comment.
Unrelated, the dependency was duplicated
ecamellini
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-842
Why?
cryptois integrated in node and it is now the standard way to do it in node/JScrypto.randomUUID()is fasterSee: