-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMN-842 - Removing uuid and using crypto #1127
base: main
Are you sure you want to change the base?
Conversation
@@ -25,16 +25,13 @@ | |||
"pagopa-interop-commons-test": "workspace:*", | |||
"@types/uuid": "9.0.8", | |||
"@types/adm-zip": "0.5.5", | |||
"pagopa-interop-commons-test": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, the dependency was duplicated
"prettier": "2.8.8", | ||
"testcontainers": "10.9.0", | ||
"ts-node": "10.9.2", | ||
"typescript": "5.4.5", | ||
"vitest": "1.6.0" | ||
}, | ||
"dependencies": { | ||
"ts-pattern": "5.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, the dependency was duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Closes IMN-842
Why?
crypto
is integrated in node and it is now the standard way to do it in node/JScrypto.randomUUID()
is fasterSee: