Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIN-5442 - Update e-service request caller assertions to accept delegates #1099

Open
wants to merge 12 commits into
base: feature/pin-5126-capofila
Choose a base branch
from
Open

PIN-5442 - Update e-service request caller assertions to accept delegates #1099

wants to merge 12 commits into from

Conversation

Carminepo2
Copy link
Contributor

@Carminepo2 Carminepo2 commented Oct 15, 2024 •
edited
Loading

Most of the changes of this PR are tests, reviewing this PR you could skip the .test files which are a bit of a copy-paste.

Splitted assertRequesterAllowed assertion functions in two: assertRequesterIsDelegateOrProducer and assertRequesterIsProducer.

assertRequesterIsDelegateOrProducer allows the requester to access the call only if:

  • there is no active delegation for the related e-service and the requester is the its producer;
  • there is an active delegation and the requester is its delegate.

@Carminepo2 Carminepo2 mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beetlecrunch beetlecrunch Awaiting requested review from beetlecrunch beetlecrunch is a code owner

@galales galales Awaiting requested review from galales galales is a code owner

@AsterITA AsterITA Awaiting requested review from AsterITA AsterITA is a code owner

@taglioni-r taglioni-r Awaiting requested review from taglioni-r taglioni-r is a code owner

@Viktor-K Viktor-K Awaiting requested review from Viktor-K

@sandrotaje sandrotaje Awaiting requested review from sandrotaje

Assignees
No one assigned
Labels
capofila catalog-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Carminepo2