Make section scrolling work with modified CSS #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
190px is hardcoded in the Javascript, whereas a user of this theme can easily override the size of the header and banner, and hence the location of the top of the main section. This change makes the scrollTop location when clicking a nav link always be correct, instead of assuming the main section is always 190px from the top.
|
Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
190px is hardcoded in the Javascript, whereas a user of this theme can easily override the size of the header and banner, and hence the location of the top of the main section. This change makes the scrollTop location when clicking a nav link always be correct, instead of assuming the main section is always 190px from the top.