Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 프로젝트 설정을 추가합니다. #64

Merged
merged 31 commits into from
Sep 9, 2023

Conversation

2-NOW
Copy link
Collaborator

@2-NOW 2-NOW commented Sep 6, 2023

📌 이슈 링크


📖 작업 배경

  • atomic component 작업을 위한 storybook 설정
  • 테스트를 위한 jest, react-testing-library 추가

🛠️ 구현 내용

  • storybook 설정 및 의존성 추가
  • jest, react-testing-library 설정 및 의존성 추가

💡 참고사항


🖼️ 스크린샷


@2-NOW 2-NOW marked this pull request as draft September 6, 2023 15:20
@2-NOW 2-NOW changed the title Chore: 프로젝트 설정을 추가합니다. chore: 프로젝트 설정을 추가합니다. Sep 6, 2023
@2-NOW 2-NOW marked this pull request as ready for review September 7, 2023 08:26
@2-NOW 2-NOW removed the request for review from InSeong-So September 7, 2023 12:08
@2-NOW 2-NOW marked this pull request as draft September 7, 2023 12:09
@2-NOW 2-NOW marked this pull request as ready for review September 7, 2023 12:09
@2-NOW 2-NOW marked this pull request as draft September 7, 2023 12:14
@2-NOW 2-NOW marked this pull request as ready for review September 7, 2023 12:14
Comment on lines 32 to 33
"dependencies": {
"@types/node": "20.5.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ dependencies에 불필요한 의존성이 섞여 있어요!

  • @types/node
  • @types/react
  • @types/react-dom
  • eslint
  • typescript

왜 불필요하다고 할까요?!

@InSeong-So InSeong-So merged commit 7651ba2 into pagers-org:team5/2-NOW Sep 9, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants