feat: Next / TypeScript / React Query / Zustand / Vanilla Extract를 사용하여 Real World 1차 기능 구현을 완료합니다. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test123
…eware를 사용하여 로그인 권한 체크
InSeong-So
approved these changes
Oct 19, 2023
| @@ -0,0 +1,43 @@ | |||
| import { HTTP_METHOD, COMMON_HEADERS } from '@/constants/api'; | |||
| import { API_BASE_URL } from '@/constants/env'; | |||
There was a problem hiding this comment.
환경변수는 상수 파일보다 .env에서 관리하면 좋을 것 같네요! 네이밍에서 그 의도를 드러낸 바와 같이 말이죠
Comment on lines
+6
to
+8
|
|
||
| constructor() {} | ||
|
|
There was a problem hiding this comment.
이러면 생성자 함수가 의미가 있을까... 싶습니다!
객체와 클래스의 차이가 무엇일까요?
Comment on lines
+9
to
+10
| async request(url: string, options: any, method: string) { | ||
| const response = await fetch(`${this.BASE_URL}${url}`, { |
There was a problem hiding this comment.
fetch API의 options는 타입 선언 파일에 제공되므로, any 보다는 해당 타입을 확장해서 사용하거나 차용하는 것을 추천드려요.
Comment on lines
+19
to
+23
| if (!response.ok) { | ||
| throw new Error(`HTTP error! Status: ${response.status}`); | ||
| } | ||
|
|
||
| return response; |
There was a problem hiding this comment.
서버 에러 또는 네트워크 에러일 때 핸들링은 어떻게 될까요?
Comment on lines
+21
to
+32
| const queryClient = useQueryClient(); | ||
|
|
||
| const onSuccess = () => { | ||
| queryClient.invalidateQueries({ queryKey: ['articles', tab] }); | ||
| }; | ||
|
|
||
| const onError = () => { | ||
| // 권한이 없을 경우 login 페이지로 이동 | ||
| router.push('/login'); | ||
| }; | ||
|
|
||
| const { favorite, unFavorite } = useArticles({ onSuccess, onError }); |
There was a problem hiding this comment.
커스텀 훅으로 분리시키면 어떨까요? 한 컴포넌트에서 너무 많은 역할을 갖고 있네요!
Comment on lines
+4
to
+18
| const useAuth = ({ | ||
| loginSuccess, | ||
| loginError, | ||
| signupSuccess, | ||
| signupError, | ||
| signoutSuccess, | ||
| signoutError, | ||
| }: { | ||
| loginSuccess?: (res: UserResponse) => void; | ||
| loginError?: (err: Error) => void; | ||
| signupSuccess?: (res: UserResponse) => void; | ||
| signupError?: (err: Error) => void; | ||
| signoutSuccess?: (res: UserResponse) => void; | ||
| signoutError?: (err: Error) => void; | ||
| }) => { |
There was a problem hiding this comment.
비슷한 프로퍼티가 너무 많은 것 같은데, 로그인/로그아웃, 회원가입/탈퇴로 묶는 건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 링크
📖 작업 배경
🛠️ 구현 내용
💡 참고사항
아래는 스터디가 끝나고 개인적으로 진행하고 싶은 부분입니다.
🖼️ 스크린샷