Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(home): 메인 페이지 마크업을 추가합니다. #117

Merged
merged 3 commits into from
Sep 21, 2023
Merged

feat(home): 메인 페이지 마크업을 추가합니다. #117

merged 3 commits into from
Sep 21, 2023

Conversation

steadily-worked
Copy link
Collaborator

@steadily-worked steadily-worked commented Sep 15, 2023 •
edited
Loading

🛠️ 구현 내용

  • 메인 페이지 마크업을 완성하였습니다.

💡 참고사항

  • 우선 뼈대부터 만들고자, 기존에 있던 HTML 파일을 그대로 갖다 붙이는 작업만 진행했습니다.
  • vanilla-extract를 사용하여 horizontal stack 컴포넌트를 만들었습니다.

🖼️ 스크린샷

  • 스크린샷 2023-09-15 오후 3 02 55

Leejha
Leejha approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@Leejha Leejha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css 넣으신 게 vanila-extract 인가요? 생각보다 새롭네요 잘봤습니다!

@steadily-worked steadily-worked merged commit 5c554dc into team10/steadily-worked Sep 21, 2023
1 check passed
@steadily-worked steadily-worked deleted the steadily-worked/add-main-page-markup branch September 21, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leejha Leejha Leejha approved these changes

@sanola2 sanola2 Awaiting requested review from sanola2

Assignees

@steadily-worked steadily-worked

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steadily-worked @Leejha