feat(txpool): calculate consumption when committing a new block #1554
+114
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
commented
Oct 17, 2024
| if trx.IsTransferTx() || trx.IsBondTx() || trx.IsWithdrawTx() { | ||
| signer := trx.Payload().Signer() | ||
| if v, ok := p.consumptionMap[signer]; ok { | ||
| p.consumptionMap[signer] = v - uint32(trx.SerializeSize()) |
There was a problem hiding this comment.
@b00f I don't know on test TestCalculatingConsumption why value p.consumptionMap for specific signer don't update.
| assert.False(t, td.pool.HasTx(testTrx.ID()), "Transaction should be removed") | ||
| assert.Nil(t, td.pool.PendingTx(testTrx.ID())) | ||
| } | ||
|
|
||
| func TestCalculatingConsumption(t *testing.T) { |
There was a problem hiding this comment.
@b00f What case need for check consumption map? I need to more details for test cases.
| @@ -325,7 +325,6 @@ func (st *state) ProposeBlock(valKey *bls.ValidatorKey, rewardAddr crypto.Addres | |||
| // Only one subsidy transaction per blk | |||
| if txs[i].IsSubsidyTx() { | |||
| st.logger.Error("found duplicated subsidy transaction", "tx", txs[i]) | |||
| st.txPool.RemoveTx(txs[i].ID()) | |||
There was a problem hiding this comment.
@b00f Please double check for remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate consumption when committing a new block
Related issue(s)