Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value of templateAlpha will be NaN if max is equal to min. #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The value of templateAlpha will be NaN if max is equal to min. #332

wants to merge 1 commit into from

Commits on Jan 12, 2021

  1. The value of templateAlpha will be NaN if max is equal to min. 

    Actually NaN does not lead to a bug, cause I find something below about globalAlpha on MDN:
"Values outside that range, including Infinity and NaN, will not be set, and globalAlpha will retain its previous value."
And, of course. The default value is 1.
However, I do not think it is a good idea to compare a number with NaN.
Hope this commit will help.
    @TerminatorSd
    TerminatorSd committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    314b509 View commit details
    Browse the repository at this point in the history