fixing non finalized transaction processing, and display name for apple

lib/controllers/fetch/price_tables_controller.dart

@@ -10,6 +10,7 @@ import 'package:shared_preferences/shared_preferences.dart';
 import 'package:how_much/custom_types.dart';
 import 'package:how_much/util/firebase_init.dart';
 import 'package:how_much/util/helper_funcs.dart';
+import 'package:how_much/util/parsing.dart';
 
 class PriceTablesController extends GetxController with WidgetsBindingObserver {
   final _firebaseService = FirebaseService();
@@ -90,13 +91,25 @@ class PriceTablesController extends GetxController with WidgetsBindingObserver {
   /// if provided, queries the given price table
   /// if not, queries the current (the newest) price table
   double? getPriceForAsset(AssetType assetType, String assetId,
-      {String priceTableDate = ""}) {
-    if (priceTableDate == "") {
+      {String priceTableDateString = ""}) {
+    if (priceTableDateString == "") {
       return priceTables
           .priceTableMap.values.last.data[assetType]?.entries[assetId];
     } else {
-      return priceTables
-          .priceTableMap[priceTableDate]!.data[assetType]?.entries[assetId];
+      DateTime priceTableDateUTC = parseDateWithHour(priceTableDateString);
+      DateTime now = DateTime.now();
+      DateTime nowUTC = now.subtract(now.timeZoneOffset);
+      if (priceTableDateUTC.difference(nowUTC).inHours > 0) {
+        // last price table date is later than `now`, means we are dealing
+        // with a non-finalized snapshot, and this price table does not exist yet
+        // use the previous price table for now
+        // this can only happen when we are processing a non-finalized transaction
+        priceTableDateString = formatDateWithHour(
+            priceTableDateUTC.subtract(const Duration(hours: 6)));
+      }
+
+      return priceTables.priceTableMap[priceTableDateString]!.data[assetType]
+          ?.entries[assetId];
     }
   }
 }

lib/controllers/fetch/transactions_controller.dart

@@ -62,8 +62,13 @@ class TransactionsController extends GetxController {
 
     await _fetchPriceTablesWithDate(sortedKeys.first);
 
-    // dummy value that does not affect the computation (null would require additional checks)
-    DateTime lastCreatedSnapshotDate = DateTime.now();
+    // we use this value to compare how many snapshots were in between current
+    // and last transaction. Since the current transaction may not be finalized
+    // we need to add at least 6 hours to `now` to ensure this check will work
+    // correctly for the first time. We could have made this null, but then
+    // we would need additional null checks for every iteration.
+    DateTime lastCreatedSnapshotDate =
+        DateTime.now().add(const Duration(days: 1));
 
     sortedTransactions.forEach((date, transactionData) {
       // Extract transaction details
@@ -115,7 +120,7 @@ class TransactionsController extends GetxController {
         Asset(
       amount: 0,
       price: _priceTablesController.getPriceForAsset(type, assetId,
-          priceTableDate: nextSnapshotDateString)!,
+          priceTableDateString: nextSnapshotDateString)!,
       category: type.name,
     );
   }
@@ -147,8 +152,10 @@ class TransactionsController extends GetxController {
     // so we should use the previous snapshot date, in order to fetch the correct price tables
 
     // find the previous update time for that timestamp with rounding down
-    String previousUpdateTime =
-        getPreviousUpdateTime(DateTime.parse(timestamp));
+    // we subtract 6 for the case the transaction may not be finalized,
+    // if so, we will need the previous price table
+    String previousUpdateTime = getPreviousUpdateTime(
+        DateTime.parse(timestamp).subtract(const Duration(hours: 6)));
 
     await _priceTablesController.fetchPriceTables(previousUpdateTime);
   }

lib/controllers/login.dart

@@ -144,5 +144,12 @@ class LoginController extends GetxController {
     FirebaseAuth.instance.signOut();
   }
 
-  String get displayName => _firebaseUser!.displayName!;
+  String get displayName {
+    try {
+      return " ${_firebaseUser!.displayName!}";
+    } catch (_) {
+      // cannot fetch display name if the auth provider is apple
+      return "";
+    }
+  }
 }

lib/controllers/snapshots_controller.dart

@@ -231,7 +231,7 @@ class SnapshotsController extends GetxController {
       assetMap.forEach((assetId, asset) {
         double price = _priceTablesController.getPriceForAsset(
             assetType, assetId,
-            priceTableDate: priceTableDateUtc)!;
+            priceTableDateString: priceTableDateUtc)!;
         assets.typeMap[assetType]![assetId]!.price = price;
       });
     });

lib/presentation/pages/main/dashboard.dart

@@ -21,7 +21,7 @@ class DashboardPage extends StatelessWidget {
   DashboardPage({super.key});
 
   final dateController = Get.find<DateController>();
-  final googleController = Get.find<LoginController>();
+  final loginController = Get.find<LoginController>();
   final reportController = Get.find<ReportController>();
   final navigationController = Get.find<NavigationController>();
 
@@ -41,7 +41,7 @@ class DashboardPage extends StatelessWidget {
                 Row(
                   children: [
                     Text(
-                        "👋 Welcome ${googleController.displayName.split(" ")[0]}!",
+                        "👋 Welcome${loginController.displayName.split(" ")[0]}!",
                         style: welcomeTextStyle),
                     const Spacer(),
                     CircleAvatar(