Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session Node Registration, Terms and Conditions, and UI Fixes #21

Merged
merged 37 commits into from
Jul 19, 2024
Merged

Session Node Registration, Terms and Conditions, and UI Fixes #21

merged 37 commits into from
Jul 19, 2024

Conversation

Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Jul 16, 2024 •
edited
Loading

Changes

  • Added hideCloseButton prop to Dialog.
  • Added Checkbox shadcn component.
  • Created Session Node registration contract hooks for approval and staking to register a solo node.
  • Added modular primary and secondary buttons to the landing page
  • Added logic to handle terms and conditions for testnet participants.
  • Corrected the logic for node staking.
  • Fixed the calculation of staked amounts displayed on node cards.
  • Fixed issues related to fee and amount types in the SENT backend JS library.
  • Fixed type issues related to NextAuth.

@Aerilym Aerilym changed the title Node Registration and TOS Session Node Registration, Terms and Conditions, and UI Fixes Jul 16, 2024
@Aerilym Aerilym requested review from yougotwill and removed request for yougotwill July 16, 2024 08:13
@Aerilym Aerilym added enhancement New feature or request @session/ui Changes to the UI library @session/contracts Changes to the Contract library @session/wallet Changes to the Wallet library staking Changes to the Staking app @session/staking-js Changes to the Staking Backend JS Client labels Jul 17, 2024
@Aerilym Aerilym requested a review from yougotwill July 17, 2024 12:14
yougotwill
yougotwill requested changes Jul 18, 2024
View reviewed changes
packages/util/tests/string.spec.ts Show resolved Hide resolved
packages/util/tests/string.spec.ts Show resolved Hide resolved
packages/util/string.ts Show resolved Hide resolved
packages/ui/package.json Show resolved Hide resolved
packages/ui/components/ui/tooltip.tsx Show resolved Hide resolved
apps/staking/app/page.tsx Show resolved Hide resolved
apps/staking/app/page.tsx Show resolved Hide resolved
apps/staking/app/page.tsx Show resolved Hide resolved
apps/staking/app/mystakes/modules/BalanceModule.tsx Show resolved Hide resolved
apps/staking/app/mystakes/modules/DailyNodeReward.tsx Show resolved Hide resolved
@yougotwill yougotwill self-requested a review July 18, 2024 03:56
yougotwill
yougotwill approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Aerilym Aerilym merged commit 43286c6 into open_nodes Jul 19, 2024
2 checks passed
@Aerilym Aerilym deleted the node_registration branch July 19, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougotwill yougotwill yougotwill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request @session/contracts Changes to the Contract library @session/staking-js Changes to the Staking Backend JS Client @session/ui Changes to the UI library @session/wallet Changes to the Wallet library staking Changes to the Staking app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aerilym @yougotwill