Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session logger #19

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Session logger #19

merged 8 commits into from
Jul 25, 2024

Conversation

Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Jul 14, 2024 •
edited
Loading

Logging utility classes for the websites and session desktop.

These classes aren't loggers themselves but wrap around a given logger to extend its functionality

@Aerilym Aerilym changed the base branch from main to query_provider July 14, 2024 23:55
Base automatically changed from query_provider to open_nodes July 16, 2024 08:08
Base automatically changed from open_nodes to main July 22, 2024 01:07
@Aerilym Aerilym requested a review from yougotwill July 22, 2024 23:44
@Aerilym Aerilym added the enhancement New feature or request label Jul 22, 2024
yougotwill
yougotwill requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work but couple of discussion points

apps/staking/package.json Show resolved Hide resolved
packages/util/logger.ts Show resolved Hide resolved
packages/util/logger.ts Show resolved Hide resolved
packages/logger/logger.ts Show resolved Hide resolved
packages/logger/logger.ts Show resolved Hide resolved
packages/logger/timedLog.ts Outdated Show resolved Hide resolved
packages/logger/timedLog.ts Show resolved Hide resolved
packages/logger/timedLog.ts Show resolved Hide resolved
packages/logger/timedLog.ts Outdated Show resolved Hide resolved
packages/logger/timedLog.ts Show resolved Hide resolved
yougotwill
yougotwill requested changes Jul 25, 2024
View reviewed changes
apps/staking/package.json Show resolved Hide resolved
packages/logger/logger.ts Show resolved Hide resolved
packages/logger/timedLog.ts Show resolved Hide resolved
packages/logger/timedLog.ts Show resolved Hide resolved
yougotwill
yougotwill approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Aerilym Aerilym merged commit dd111a6 into main Jul 25, 2024
2 checks passed
@Aerilym Aerilym deleted the session_logger branch July 25, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougotwill yougotwill yougotwill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aerilym @yougotwill