Improved landing page hero and header responsiveness #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yougotwill
commented
Jul 5, 2024
yougotwill
commented
- Added footer to landing page
stay on 0.32.6 because there are issues with the later versions
added support for external links
Aerilym
requested changes
Jul 9, 2024
| @@ -25,7 +26,8 @@ | |||
| "ariaSupport": "Go to support page", | |||
| "faucet": "Faucet", | |||
| "ariaFaucet": "Go to faucet page" | |||
| } | |||
| }, | |||
| "managedBy": "/ Managed by the Session Network" | |||
There was a problem hiding this comment.
Session Network should be a variable, and that variable should be defined in locale-defaults.tsx
| @@ -15,6 +15,7 @@ | |||
| "stake": "Stake Now", | |||
| "myStakes": "My Stakes", | |||
| "docs": "Docs", | |||
| "tokenSite": "Session Token", | |||
There was a problem hiding this comment.
Session Token should be in locale-defaults.tsx and/or in the constants
Aerilym
added a commit
that referenced
this pull request
Jul 9, 2024
Improved landing page hero and header responsiveness #10 Continued
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.