Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of small Xcode 16 build fixes #1028

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Number of small Xcode 16 build fixes #1028

wants to merge 1 commit into from

Conversation

mpretty-cyro
Copy link
Collaborator

  • Renamed an init which matched a private API so triggered a store submission warning
  • Fixed a unit test build issue in Xcode 16
  • Updated the LintLocalizableStrings updatePermissionStrings output to be sorted (so it doesn't change every time)
  • Moved the 'Ensure InfoPlist.xcstrings updated' build step to the Session target

@mpretty-cyro
Number of small Xcode 16 build fixes
7086fe1 
• Renamed an init which matched a private API so triggered a store submission warning
• Fixed a unit test build issue in Xcode 16
• Updated the LintLocalizableStrings updatePermissionStrings output to be sorted (so it doesn't change every time)
• Moved the 'Ensure InfoPlist.xcstrings updated' build step to the Session target
@mpretty-cyro mpretty-cyro self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanRory RyanRory RyanRory approved these changes

Assignees

@mpretty-cyro mpretty-cyro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpretty-cyro @RyanRory