Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SES 1792] Standardised message deletion #1518

Draft
wants to merge 31 commits into
base: dev
Choose a base branch
from
Draft

[SES 1792] Standardised message deletion #1518

wants to merge 31 commits into from

Commits on Jun 11, 2024

  1. Initial commit with high level structure for new message deletion logic

    @ThomasArtProcessors
    ThomasArtProcessors committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9f1fa6b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Adding admin logic

    @ThomasSession
    ThomasSession committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c66138e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. New dialog styles

    @ThomasSession
    ThomasSession committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6869cbd View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Matching existing dialog closer to new designs

    @ThomasSession
    ThomasSession committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2d45804 View commit details
    Browse the repository at this point in the history

  2. Using the theme attribute danger instead of a hardcoded colour

    @ThomasSession
    ThomasSession committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b90be0a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Using classes for the dialogs 

    Also cleaned up older references to align with newer look
    @ThomasSession
    ThomasSession committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    660a815 View commit details
    Browse the repository at this point in the history

  2. Adding cancel handling 

    Cleaning unused code
    @ThomasSession
    ThomasSession committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c43334d View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Handling local deletion with batch message deletion

    @ThomasSession
    ThomasSession committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8daffab View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Reusing the 'delete locally'

    @ThomasSession
    ThomasSession committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e501f7d View commit details
    Browse the repository at this point in the history

  2. Delete on device should "marl the message as deleted", not remove it … 

    …from the db directly
    @ThomasSession
    ThomasSession committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6e315a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Displaying "marked as deleted" messages 

    Split the `BASE_DELETED_TYPE` into two types:
BASE_DELETED_OUTGOING_TYPE and BASE_DELETED_INCOMING_TYPE
so we can differentiate them visually.
    @ThomasSession
    ThomasSession committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7a7d04b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'dev' into SES-1792]-Standardised-Message-Deletion-

    @ThomasSession
    ThomasSession committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d3c7a66 View commit details
    Browse the repository at this point in the history

  2. Proper handling of merged code

    @ThomasSession
    ThomasSession committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    13ee083 View commit details
    Browse the repository at this point in the history

  3. Removed temp bg color

    @ThomasSession
    ThomasSession committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5dedc77 View commit details
    Browse the repository at this point in the history

  4. Making sure the deleted message view is visible

    @ThomasSession
    ThomasSession committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0b3d048 View commit details
    Browse the repository at this point in the history

  5. Renaming functions for clarity

    @ThomasSession
    ThomasSession committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    584b013 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Adding the ability to customise the text for the deleted control mess… 

    …ages
    @ThomasSession
    ThomasSession committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7510166 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'dev' into SES-1792]-Standardised-Message-Deletion-

    @ThomasSession
    ThomasSession committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d30f8eb View commit details
    Browse the repository at this point in the history

  2. Removing code that was added back from merging dev back in

    @ThomasSession
    ThomasSession committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7d94a52 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'dev' into SES-1792]-Standardised-Message-Deletion-

    @ThomasSession
    ThomasSession committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    07071e5 View commit details
    Browse the repository at this point in the history

  2. Using the updated strings

    @ThomasSession
    ThomasSession committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    58826d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Toast confirmation on 'delete locally'

    @ThomasSession
    ThomasSession committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f73e022 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Recreating xml dialogs in Compose and moved logic in VM

    @ThomasSession
    ThomasSession committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ed38e50 View commit details
    Browse the repository at this point in the history

  2. Removing hardcoded strings

    @ThomasSession
    ThomasSession committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2861b3a View commit details
    Browse the repository at this point in the history

  3. Updated message deletion logic 

    Still need to finalise "note to self" and "legacy groups"
    @ThomasSession
    ThomasSession committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    28498c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Deletion logic rework 

    Moving away from promises
    @ThomasSession
    ThomasSession committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    792a4ca View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. More deletion logic 

    Hndling unsend request retrieval as per figma docs
    @ThomasSession
    ThomasSession committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2e14b0e View commit details
    Browse the repository at this point in the history

  2. Making sure multi-select works as expectec

    @ThomasSession
    ThomasSession committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2b54193 View commit details
    Browse the repository at this point in the history

  3. Multi message handling 

    Sharing admin logic
    @ThomasSession
    ThomasSession committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    036fd4e View commit details
    Browse the repository at this point in the history

  4. Deleting reactions when deleting a message

    @ThomasSession
    ThomasSession committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0391c52 View commit details
    Browse the repository at this point in the history

  5. Deleting reactions when deleting a message

    @ThomasSession
    ThomasSession committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a7b4c8d View commit details
    Browse the repository at this point in the history