Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cmd field to the status command #1849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wir3z
Copy link
Contributor

@wir3z wir3z commented Sep 15, 2024

Small addition to the 'status' command to retrieve if 'remoteConfiguration' is allowed. I added to to a 'cmd' field in the status command.

Useful to determine if the phone can be remotely configured when using it in a centrally managed implementation.

This would be a nice to have on the iOS side as well to track the 'cmd' slider.

@ckrey
Copy link
Member

ckrey commented Sep 16, 2024

This does not make sense because the "status" command only works (returns a result) if "cmd" is enabled

@wir3z
Copy link
Contributor Author

wir3z commented Sep 16, 2024

This does not make sense because the "status" command only works (returns a result) if "cmd" is enabled

Ahh is that how iOS is configured? Android has 2-sliders. One for remote commands another for remote configuration. I can get the status back as long as remote commands is enabled.

@@ -5,6 +5,7 @@
## New features

- OSM map is a little easier to zoom without accidentally rotating.
- Added `cmd` field to the `status` command to retrieve if `remoteConfiguration` is allowed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/if/whether/

@jpmens
Copy link
Member

jpmens commented Sep 17, 2024

I too thought (and thusly it is documented) that cmd means I can remotely configure the app. IMO the remoteconfig switch on Android could be removed to attain iOS parity.

I don't really see a use-case for permitting cmd but not its setConfiguration subcommand.

@ckrey
Copy link
Member

ckrey commented Sep 17, 2024

in iOS we have the "dump" cmd, which sends the complete configuration. Opposed to this, "status" provides information of settings on the device, which are done locally, not via configuration.

@wir3z
Copy link
Contributor Author

wir3z commented Sep 17, 2024

I too thought (and thusly it is documented) that cmd means I can remotely configure the app. IMO the remoteconfig switch on Android could be removed to attain iOS parity.

I don't really see a use-case for permitting cmd but not its setConfiguration subcommand.

I agree with that statement.

@wir3z
Copy link
Contributor Author

wir3z commented Sep 20, 2024

For iOS, what happens if you send a command request with the cmd slider off? Does it silently reject it?

I'm looking for a way a centrally managed system could flag phones that it could not synchronize settings with.

@growse growse force-pushed the master branch 14 times, most recently from d7e06e2 to e60ca38 Compare September 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants