feat: emit SequencerOracleUpdated on contract creation

overlay-market · May 8, 2024 · d030fab · d030fab
1 parent 94fa241
commit d030fab
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/contracts/OverlayV1Factory.sol b/contracts/OverlayV1Factory.sol
@@ -132,7 +132,7 @@ contract OverlayV1Factory is IOverlayV1Factory {
         deployer = new OverlayV1Deployer(_ov);
 
         // set the sequencer oracle
-        sequencerOracle = AggregatorV3Interface(_sequencerOracle);
+        _setSequencerOracle(_sequencerOracle);
         _setGracePeriod(_gracePeriod);
     }
 
@@ -253,8 +253,7 @@ contract OverlayV1Factory is IOverlayV1Factory {
     }
 
     function setSequencerOracle(address newSequencerOracle) public onlyGovernor {
-        sequencerOracle = AggregatorV3Interface(newSequencerOracle);
-        emit SequencerOracleUpdated(newSequencerOracle);
+        _setSequencerOracle(newSequencerOracle);
     }
 
     function setGracePeriod(uint256 newGracePeriod) public onlyGovernor {
@@ -265,4 +264,10 @@ contract OverlayV1Factory is IOverlayV1Factory {
         gracePeriod = newGracePeriod;
         emit GracePeriodUpdated(newGracePeriod);
     }
+
+    function _setSequencerOracle(address newSequencerOracle) internal {
+        require(newSequencerOracle != address(0), "OVV1: sequencerOracle should not be zero address");
+        sequencerOracle = AggregatorV3Interface(newSequencerOracle);
+        emit SequencerOracleUpdated(newSequencerOracle);
+    }
 }