Skip to content

Commit

Permalink
Refactor heartbeat event name and extract internal function for setti…
Browse files Browse the repository at this point in the history
…ng heartbeat
  • Loading branch information
magnetto90 committed Mar 18, 2024
1 parent 1a875d9 commit b440e00
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions contracts/feeds/chainlink/OverlayV1ChainlinkFeed.sol
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ contract OverlayV1ChainlinkFeed is OverlayV1Feed {
uint256 public heartbeat;
string public description;

event HeartbeatUpdated(uint256 heartbeat);
event HeartbeatSet(uint256 heartbeat);

modifier onlyGovernor() {
require(ov.hasRole(GOVERNOR_ROLE, msg.sender), "OVV1: !governor");
Expand All @@ -31,7 +31,7 @@ contract OverlayV1ChainlinkFeed is OverlayV1Feed {
aggregator = AggregatorV3Interface(_aggregator);
decimals = aggregator.decimals();
description = aggregator.description();
heartbeat = _heartbeat;
_setHeartbeat(_heartbeat);
ov = IOverlayV1Token(_ov);
}

Expand Down Expand Up @@ -125,7 +125,11 @@ contract OverlayV1ChainlinkFeed is OverlayV1Feed {
}

function setHeartbeat(uint256 _heartbeat) external onlyGovernor {
_setHeartbeat(_heartbeat);
}

function _setHeartbeat(uint256 _heartbeat) internal {
heartbeat = _heartbeat;
emit HeartbeatUpdated(_heartbeat);
emit HeartbeatSet(_heartbeat);
}
}

0 comments on commit b440e00

Please sign in to comment.