feat(market): emit Update event on every action

overlay-market · May 16, 2024 · a5c6f39 · a5c6f39
1 parent 2996e66
commit a5c6f39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/contracts/OverlayV1Market.sol b/contracts/OverlayV1Market.sol
@@ -148,7 +148,7 @@ contract OverlayV1Market is IOverlayV1Market, Pausable {
 
     /// @param oiLong oiLong after public update
     /// @param oiShort oiShort after public update
-    event PublicUpdate(uint256 oiLong, uint256 oiShort);
+    event Update(uint256 oiLong, uint256 oiShort);
 
     constructor() {
         (address _ov, address _feed, address _factory) =
@@ -517,10 +517,9 @@ contract OverlayV1Market is IOverlayV1Market, Pausable {
     /// @dev update is called every time market is interacted with
     function update() external returns (Oracle.Data memory data) {
         data = _update();
-        emit PublicUpdate(oiLong, oiShort);
     }
 
-    function _update() private whenNotPaused returns (Oracle.Data memory) {
+    function _update() internal whenNotPaused returns (Oracle.Data memory) {
         // pay funding for time elasped since last interaction w market
         _payFunding();
 
@@ -533,6 +532,7 @@ contract OverlayV1Market is IOverlayV1Market, Pausable {
         Oracle.Data memory data = IOverlayV1Feed(feed).latest();
         require(dataIsValid(data), "OVV1:!data");
 
+        emit Update(oiLong, oiShort);
         // return the latest data from feed
         return data;
     }

diff --git a/tests/OverlayV1Market.t.sol b/tests/OverlayV1Market.t.sol
@@ -172,9 +172,9 @@ contract MarketTest is Test {
         assertEq(ov.balanceOf(address(market)), 0);
     }
 
-    event PublicUpdate(uint256 oiLong, uint256 oiShort);
+    event Update(uint256 oiLong, uint256 oiShort);
 
-    function testUpdate() public {
+    function testUpdateEventEmitting() public {
         vm.startPrank(USER);
 
         ov.approve(address(market), type(uint256).max);
@@ -193,7 +193,7 @@ contract MarketTest is Test {
         uint256 newoiShort = isLongOverweight ? oiUnderweight : oiOverweight;
 
         vm.expectEmit(false, false, false, true);
-        emit PublicUpdate(newoiLong, newoiShort);
+        emit Update(newoiLong, newoiShort);
         market.update();
 
         vm.stopPrank();