POC feat: add support for celery multiqueue #1131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
force-pushed
the
cag/celery-queues
branch
from
2121bcb
to
008bf0b
Compare
Ian2012
force-pushed
the
cag/celery-queues
branch
from
008bf0b
to
f257d3f
Compare
regisb
reviewed
Oct 7, 2024
| @@ -514,6 +514,9 @@ def your_filter_callback(some_data): | |||
| #: :param str file_path: The path to the file being checked. | |||
| IS_FILE_RENDERED: Filter[bool, [str]] = Filter() | |||
|
|
|||
| #: List of workers | |||
| CELERY_WORKERS_CONFIG: Filter[dict[str, dict[str, Any]], []] = Filter() | |||
There was a problem hiding this comment.
I'm not in favor of a filter that would be used to create extra containers. There is already another mechanisms to do that, which is patching the docker-compose/deployments.yml files. Let's avoid creating another one.
Let's continue this conversation in the corresponding issue (#1130).
Ian2012
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to deploy multiple Celery deployments with different settings and queues for each one: