Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pm: print command name to stdout #14266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pm: print command name to stdout #14266

wants to merge 2 commits into from
+717 −210

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Oct 1, 2024

Closes #1130

@robobun
Copy link

robobun commented Oct 1, 2024 •
edited
Loading

❌ @nektro, your commit 7e45e71 has 13 failures in #4130:

  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64
  • test/js/node/watch/fs.watch.test.ts - 3 failing on 🍎 14 x64
  • test/js/node/test/parallel/worker-cleanexit-with-moduleload.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baseline
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 2 failing on 🪟 x64
  • test/js/bun/http/bun-serve-static.test.ts - 2 failing on 🍎 14 aarch64
  • test/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 13 aarch64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
    		•

    @nektro nektro marked this pull request as ready for review October 1, 2024 07:53
    Jarred-Sumner
    Jarred-Sumner reviewed Oct 1, 2024
    View reviewed changes
    test/cli/install/bun-workspaces.test.ts
    @@ -212,12 +224,13 @@ test("adding workspace in workspace edits package.json with correct version (wor
    cmd: [bunExe(), "add", "pkg2@workspace:*"],
    cwd: join(packageDir, "packages", "pkg1"),
    stdout: "pipe",
    stderr: "inherit",
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Why change this? it will only make it harder to debug test failures.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Jarred-Sumner Jarred-Sumner Jarred-Sumner left review comments

    @dylan-conway dylan-conway Awaiting requested review from dylan-conway

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Bun Install prints to stderr
    3 participants
    @nektro @robobun @Jarred-Sumner