Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for unsupported params file syntax in composable node python launch [Foxy] #327

Open
wants to merge 2 commits into
base: ros2-foxy
Choose a base branch
from
Open

Workaround for unsupported params file syntax in composable node python launch [Foxy] #327

wants to merge 2 commits into from

Commits on May 10, 2024

  1. fix: Implement a workaround for invalid composable node parameter par… 

    …sing under foxy.

* This wraps the composable node launch description definitions into a separate function that reads the parameters file directly and extracts parameters for each node.
* The function is then called as an OpaqueFunction launch entity, which allows access to the inner values of LaunchConfiguration entities.
* This also maintains correct support for the user-provided 'params_file' and 'ouster_ns' arguments.
    @Imaniac230
    Imaniac230 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ac35d08 View commit details
    Browse the repository at this point in the history

  2. fix: Add missing 'ros__parameters' key in os_image params.

    @Imaniac230
    Imaniac230 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    05629a1 View commit details
    Browse the repository at this point in the history