Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding error #460

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix encoding error #460

merged 2 commits into from
May 28, 2024

Conversation

neokry
Copy link
Collaborator

@neokry neokry commented May 28, 2024

Description

Encoding init params for token would fail due to viem changes

Motivation & context

Code review

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nouns-builder ✅ Ready (Inspect) Visit Preview May 28, 2024 1:35am
testnet-nouns-builder ✅ Ready (Inspect) Visit Preview May 28, 2024 1:35am

@isaaczaak isaaczaak self-requested a review May 28, 2024 01:32
@neokry neokry merged commit 548247d into main May 28, 2024
2 of 3 checks passed
@neokry neokry deleted the fix-encoding-error branch May 28, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaczaak isaaczaak isaaczaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neokry @isaaczaak